Skip to content

magento/magento2#19071: Password strength indicator shows No Password…#19073

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
dimasalamatov:password-strength-bug
Nov 9, 2018
Merged

magento/magento2#19071: Password strength indicator shows No Password…#19073
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
dimasalamatov:password-strength-bug

Conversation

@dimasalamatov
Copy link
Contributor

@dimasalamatov dimasalamatov commented Nov 5, 2018 •
edited
Loading

… even when a password is entered

Description (*)

The password strength indicator shows "No Password" at times when there is a password entered and "Number of Required Character Classes" option has value "1". There is an situation when zxcvbn() method returns 0 score value and password is valid. In this case displayScore variable will be 0 and as result text "Password Strength: No Password" is visible despite the fact that "Password" field is filled.
Added additional condition that checks if zxcvbn() returns 0 and pass is valid, then displayScore = 1 and
"Password Strength: Weak"

Link to the same PR for 2.3-develop : #19087

Manual testing scenarios (*)

  1. Goto AdminPanel->Stores->Configuration->Customers->Customer Configuration->Password Options
  2. Set "Number of Required Character Classes" to 1
  3. Go to "Create account" page
  4. Type to "Password" field any words which have 8 lowercase letters like "password", "aaaaaaaa", etc
  5. Check that "Password Strength:" not equal "No Password" in this case

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Customer Release Line: 2.2 labels Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 5, 2018

Hi @dimasalamatov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Nov 6, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 6, 2018

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2018

Hi @dimasalamatov , please, sign CLA, otherwise, we can't process your pull request

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 6, 2018

Hi @rogyar, here is your Magento instance.
Admin access: http://34.228.235.121/i-19073-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Nov 6, 2018

Hi @dimasalamatov. Thank you for the contribution. According to the Code Contributions Guideline (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#rules) we can accept the change to 2.2-develop branch only if it's present in 2.3-develop branch.
The issue is also reproducible on 2.3-develop branch. Please, consider creating the same PR for 2.3-develop branch and leave the reference to the newly created PR here (in the description).
Thank you.

@rogyar rogyar self-assigned this Nov 6, 2018
@dimasalamatov dimasalamatov mentioned this pull request Nov 6, 2018
Merged
4 tasks
@dimasalamatov
Copy link
Contributor Author

dimasalamatov commented Nov 6, 2018

Hi @rogyar
Created PR with this fix for 2.3-develop branch. Added link to this PR in description

@orlangur orlangur added the Port label Nov 7, 2018
@orlangur orlangur self-assigned this Nov 7, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 7, 2018

Hi @orlangur, thank you for the review.
ENGCOM-3404 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit c8ead23 into magento:2.2-develop Nov 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 9, 2018
ENGCOM-3404: #19071: Password strength indicator shows No Password… #…
5283582 
…19073
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 9, 2018

Hi @dimasalamatov. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

@swnsma swnsma mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@rogyar rogyar

Labels

Area: Frontend Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@dimasalamatov @magento-engcom-team @rogyar @sidolov @orlangur